loadtxt/savetxt: do not require space after last entry
#877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
I'm never sure about these string formats, so I went test it here. It seems like all most used compilers do add a space at the end. After this PR we will have an error message, so if those tests fail again, we will hopefully know why (I've never had any errors testing on my machine locally). |
Co-authored-by: Jeremie Vandenplas <[email protected]>
|
Can this PR be merged, @perazz ? |
|
As there have been no further comments, I will merge @jvdp1. Thanks for the review and approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to address #862.
The current formats require an end-of-row space both in
savetxtandloadtxt, i.e.,This PR proposes to not require a space after the last record, i.e.,
This should hopefully improve the seldom crashing CI tests.
@fortran-lang/stdlib @chuckyvt @minhqdao
PS: these routines would benefit from some form of error control in the
readandwritestatements.Without changing the API, I propose checking for
iostatandiomsg, so that when something goes wrong, an error can be produced to give information about what happened (what file, which line).